Return to Issues Table 

WFS-T wrong check for deleted property value

Issue ID#:
946
Category:
WFS 2.0
Type:
Issue
Status:
Fixed - Requires Review
Priority:
Normal
Entered By:
Fischer, Jean-Michel
Created On:
2014-04-24 07:19:31
Updated By:
Bermudez, Luis
Last Update:
2014-07-24 18:25:51
Assigned To:
Martell, Richard

Original Issue Details:

in the WFS-transactional tests TE sends the following Update request:


    xmlns:tns="http://www.interactive-instruments.de/namespaces/cite/wfst"
    xmlns:gml="http://www.opengis.net/gml/3.2" service="WFS" version="2.0.0">
            typeName="ns69:City">
       
            tns:inhabitants[1]
           
       
       
           
       
   


as you can see the is empty and after that this field is empty in the database. The SUT answers:


    xmlns:fes="http://www.opengis.net/fes/2.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://www.opengis.net/wfs/2.0 http://services.interactive-instruments.de/cite2013tp/schema/ogc/wfs/2.0/wfs.xsd">;
   
        1
   


OK.

Then TE send a GetFeature request:

http://services.interactive-instruments.de/cite2013tp/cgi-bin/sf/wfs?service=WFS&version=2.0.0&request=GetFeature&count=10&startindex=0&storedquery_id=urn:ogc:def:query:OGC-WFS::GetFeatureById&id=City.71

the SUT answers correctly:


    xmlns:gml="http://www.opengis.net/gml/3.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://www.interactive-instruments.de/namespaces/cite/wfst http://services.interactive-instruments.de/cite2013tp/schema/wfst.xsd http://www.opengis.net/gml/3.2 http://services.interactive-instruments.de/cite2013tp/schema/ogc/gml/3.2.1/gml.xsd http://www.opengis.net/gml/3.2 http://services.interactive-instruments.de/cite2013tp/schema/ogc/gml/3.2.1/gml.xsd">;
    Ce n'est pas Vieux-Port de Montréal!
   
                    srsDimension="2">
            50.936400000000 6.959100000000
       
   
    70
    Köln


as the inhabitants property is optional it is not in the response.

Then TE throws an Exception:

Apr 24, 2014 1:09:24 PM org.opengis.cite.iso19142.util.TestSuiteLogger log
WARNING: XPath expression cannot be evaluated: tns:inhabitants[1] = ''.
com.sun.org.apache.xpath.internal.domapi.XPathStylesheetDOM3Exception: Präfix muss als Namespace aufgelöst werden: tns
    at com.sun.org.apache.xpath.internal.compiler.XPathParser.errorForDOM3(XPathParser.java:657)
    at com.sun.org.apache.xpath.internal.compiler.Lexer.mapNSTokens(Lexer.java:642)
    at com.sun.org.apache.xpath.internal.compiler.Lexer.tokenize(Lexer.java:269)
    at com.sun.org.apache.xpath.internal.compiler.Lexer.tokenize(Lexer.java:100)
... ... ...

The namespace prefix is ci and not tns for inhabitants.


Status: new
Assigned To:

Addendum:


After this test the Database is somehow "broken", as the deleted PropertyValue is not being inserted again.


 

Hours Worked: 0.00
Entered By: Fischer, Jean-Michel - 2014-10-23 11:54:13
Status: new
Assigned To: Martell, Richard

This report pertains to the Update#updateSimplePropertyValue test? This WFS implementation reports ImplementsTransactionalWFS = "FALSE":


http://services.interactive-instruments.de/cite2013wfs/simpledemo/cgi-bin/cities-postgresql/wfs?request=GetCapabilities&service=WFS


Does it in fact support transaction requests if I set this to "TRUE"?


The 'tns' namespace prefix doesn't matter here, but the correct namespace binding was not specified so the assertion check (ETSAssert.assertFeatureProperties) failed. This has been fixed.

Hours Worked: 0.00
Entered By: Martell, Richard - 2014-10-23 11:54:13
18
Status: new
Assigned To: Martell, Richard

Following the update request, a GetFeatureById stored query is submitted to retrieve the modified feature. The assumption is that a complete representation is returned (i.e. including all non-null properties). Clauses 7.9.3.6, 11.3.5 don't suggest otherwise.


Note that cl. 7.9.2.4.5.1 applies to ad hoc query expressions, not stored queries.

Hours Worked: 0.00
Entered By: Martell, Richard - 2014-10-23 11:54:13
Status: new
Assigned To: Martell, Richard

The updated feature wasn't restored because the exception occurred. This should no longer occur.

Hours Worked: 0.00
Entered By: Martell, Richard - 2014-10-23 11:54:13
Status: new
Assigned To: Martell, Richard

Richard,


this WFS is not transactional. I'll test your changes as soon as possible.


Thanks


Jean-Michel

Hours Worked: 0.00
Entered By: Fischer, Jean-Michel - 2014-10-23 11:54:13
Status: Fixed - Requires Review
Assigned To: Martell, Richard

Jean-Michel,


The test suite is now at GitHub: https://github.com/opengeospatial/ets-wfs20


 

Hours Worked: 0.00
Entered By: Martell, Richard - 2014-06-09 12:44:53
Status: Fixed - Requires Review
Assigned To: Martell, Richard

Moved to GitHub: https://github.com/opengeospatial/ets-wfs20/issues/7

Hours Worked: 0.00
Entered By: Bermudez, Luis - 2014-07-24 18:25:51