Return to Issues Table 

Tests fail but the response seems valid

Issue ID#:
943
Category:
WMS 1.1.1
Type:
Issue
Status:
Closed (Feature Suggestion)
Priority:
Normal
Entered By:
Fischer, Jean-Michel
Created On:
2014-03-28 04:00:04
Updated By:
Bermudez, Luis
Last Update:
2014-07-24 19:06:57
Assigned To:
Martell, Richard

Original Issue Details:
The following tests fail:

Test wms:wmsops-getfeatureinfo-params-query_layers-1
Test wms:wmsops-getfeatureinfo-params-query_layers-2
Test wms:wmsops-getfeatureinfo-params-query_layers-3
Test wms:wmsops-getfeatureinfo-params-query_layers-4

but our SUT answers (imho) correctly.

For example:
http://services.interactive-instruments.de/cite2013wfs/cite/cgi-bin/wms/wms/wms?&ReQuEsT=GetFeatureInfo&QuErY_LaYeRs=cite:Lakes&BbOx=0,-0.0020,0.0040,0&X=60&VeRsIoN=1.1.1&InFo_fOrMaT=text/xml;subtype=gml/2.1.2&WiDtH=200&LaYeRs=cite:Lakes&SrS=EPSG:4326&FoRmAt=image/gif&StYlEs=&HeIgHt=100&Y=60

The response is an not empty FeatureCollection.

Status: new
Assigned To: Goerke, Sebastian

Hours Worked: 0.00
Entered By: Bermudez, Luis - 2014-10-23 11:54:13
Status: new
Assigned To: Goerke, Sebastian

Issue 918 is related to this Issue.


The test wms:basic_elements-param_rules-order_and_case-5 fails as well. BUt the Response is valid. 


Example:


Request:


http://services.interactive-instruments.de/cite2013wfs/cite/cgi-bin/wms/wms/wms?&SrS=EPSG:4326&X=60&FoRmAt=image/gif&InFo_fOrMaT=text/xml;subtype=gml/2.1.2&Y=60&WiDtH=200&QuErY_LaYeRs=cite:Lakes&LaYeRs=cite:Lakes&BoGuS=ignored&BbOx=0,-0.0020,0.0040,0&VeRsIoN=1.1.1&HeIgHt=100&StYlEs=&ReQuEsT=GetFeatureInfo


Response:


<?xml version="1.0" encoding="utf-8"?>
<wfs:FeatureCollection xmlns:cblf="http://www.opengis.net/cite/bluelake"
    xmlns:gml="http://www.opengis.net/gml" xmlns:wfs="http://www.opengis.net/wfs"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://www.opengis.net/cite/bluelake http://services.interactive-instruments.de/cite2013wfs/cite/cgi-bin/wms/wms/wfs?SERVICE=WFS&amp;OUTPUTFORMAT=text%2fxml%3b%20subtype%3dgml%2f2%2e1%2e2&amp;VERSION=1.0.0&amp;REQUEST=DescribeFeatureType&amp;TYPENAME=cblf%3aLakeFeature&amp;NAMESPACE=xmlns(cblf=http%3a%2f%2fwww%2eopengis%2enet%2fcite%2fbluelake)&amp; http://www.opengis.net/gml http://services.interactive-instruments.de/cite2013wfs/cite/schema/ogc/gml/2.1.2/feature.xsd http://www.opengis.net/gml/3.2 http://services.interactive-instruments.de/cite2013wfs/cite/schema/ogc/gml/3.2.1/gml.xsd http://www.opengis.net/wfs http://services.interactive-instruments.de/cite2013wfs/cite/schema/ogc/wfs/1.0.0/WFS-basic.xsd">;
    <gml:boundedBy>
        <gml:Box srsName="urn:ogc:def:crs:EPSG::4326">
            <gml:coordinates>-0.0018,0.0006 -0.0001,0.0031</gml:coordinates>
        </gml:Box>
    </gml:boundedBy>
    <gml:featureMember>
        <cblf:LakeFeature fid="LakeFeature.1">
            <cblf:name>Blue Lake</cblf:name>
            <cblf:shore>
                <gml:Polygon srsName="urn:ogc:def:crs:EPSG::4326">
                    <gml:outerBoundaryIs>
                        <gml:LinearRing>
                            <gml:coordinates>-0.0018,0.0006 -0.0006,0.001 -0.0001,0.0024 -0.0015,0.0031 -0.0018,0.0006</gml:coordinates>
                        </gml:LinearRing>
                    </gml:outerBoundaryIs>
                    <gml:innerBoundaryIs>
                        <gml:LinearRing>
                            <gml:coordinates>-0.0011,0.0017 -0.0011,0.0025 -0.0006,0.0025 -0.0006,0.0017 -0.0011,0.0017</gml:coordinates>
                        </gml:LinearRing>
                    </gml:innerBoundaryIs>
                </gml:Polygon>
            </cblf:shore>
        </cblf:LakeFeature>
    </gml:featureMember>
</wfs:FeatureCollection>


 


 

Hours Worked: 0.00
Entered By: Fischer, Jean-Michel - 2014-10-23 11:54:13
Status: new
Assigned To: Martell, Richard

What went wrong here is, that the tests evaluate the content-type:


<xsl:for-each select="$request1">


        <xsl:if test="not(normalize-space(substring-before(concat(/headers/header[translate(name, 'CONTYPE', 'contype') = 'content-type']/value, ';'), ';'))=$VAR_GET_FEATURE_INFO_FORMAT)">


          <fail/>


        </xsl:if>


      </xsl:for-each>


Anyhow, the comparison between the content-type and the infoformat fails, but both values are: text/xml;subtype=gml/2.1.2


Maybe this is a parser problem? @Richard, what would you say?

Hours Worked: 0.00
Entered By: Goerke, Sebastian - 2014-10-23 11:54:13
Status: Responded
Assigned To: Martell, Richard

Hours Worked: 0.00
Entered By: Goerke, Sebastian - 2014-05-05 09:17:19
Status: Responded
Assigned To: Martell, Richard

The substring-before function prunes all media type parameters (starting at the first ';' char). So this expression will always fail if the advertised media type includes any parameters.

Hours Worked: 0.00
Entered By: Martell, Richard - 2014-05-06 18:01:49
Status: Responded
Assigned To: Goerke, Sebastian

For some reason the expression appends a semicolon to the media type and then ignores it. To select a header by name in a case-insensitive manner:


/headers/header[matches(name,'Content-Type','i')]/value


The full expression should probably be the following:


/headers/header[matches(name,'Content-Type','i')]/value ne $VAR_GET_FEATURE_INFO_FORMAT

Hours Worked: 0.00
Entered By: Martell, Richard - 2014-05-06 18:21:23
Status: Fixed - Requires Review
Assigned To: Martell, Richard

Fixed in r6. Modified XPath expression as suggested.

Hours Worked: 0.00
Entered By: Martell, Richard - 2014-06-05 18:27:51
Status: Fixed - Requires Review
Assigned To: Martell, Richard

Fixed deployed in OGC Beta Facility 20140619: https://github.com/opengeospatial/cite/issues/15

Hours Worked: 0.00
Entered By: Bermudez, Luis - 2014-06-20 09:16:52
Status: Fixed - Requires Review
Assigned To: Martell, Richard

This one is working now, thanks!

Hours Worked: 0.00
Entered By: Fischer, Jean-Michel - 2014-07-07 03:31:01
Status: Fixed - Requires Review
Assigned To: Martell, Richard

This test:

wms:basic_elements-param_rules-order_and_case-5

might fail for the same reason as the fixed ones above?

Because the assertion seems to be the "old" one?

<xsl:if test="not(normalize-space(substring-before(concat(/headers/header[translate(name, 'CONTYPE', 'contype') = 'content-type']/value, ';'), ';'))=$VAR_GET_FEATURE_INFO_FORMAT)">

Hours Worked: 0.00
Entered By: Fischer, Jean-Michel - 2014-07-07 07:31:05
Status: Closed (Feature Suggestion)
Assigned To: Martell, Richard

Moved to GitHub: https://github.com/opengeospatial/ets-wms11/issues/4. Please provide further comments in the GitHub issue tracker.

Hours Worked: 0.00
Entered By: Bermudez, Luis - 2014-07-24 19:06:57