Return to Issues Table 

verifyUpdateTarget assumes updates are delivered with original data

Issue ID#:
941
Category:
KML 2.2
Type:
Issue
Status:
Closed (Change Required)
Priority:
Normal
Entered By:
Martell, Richard
Created On:
2014-03-18 15:06:40
Updated By:
Bermudez, Luis
Last Update:
2014-07-24 09:04:11
Assigned To:
Martell, Richard

Original Issue Details:

The test method verifyUpdateTarget (in org.opengis.cite.kml22.level1.LinkTests) expects all NetworkLink elements to occur in the same document. In practice this will rarely be the case; the update data may be loaded into an "earth browser" separately from the original data.


In ATC 22 (Update - targetHref), the second constraint (on kml:Update/kml:targetHref) can't really be applied to a single KML document in the manner intended by the KML 2.2 specification (see cl. 13.3):


"Specifies an addition, change, or deletion to a KML resource that has previously been retrieved via kml:NetworkLink."


 


Status: new
Assigned To: Martell, Richard



The example at https://developers.google.com/kml/documentation/updates makes this rather more obvious, where the NetworkLink elements are in separate documents loaded into a specific client application.

Hours Worked: 0.00
Entered By: Martell, Richard - 2014-10-23 11:54:13
Status: new
Assigned To: Martell, Richard

The second constraint in ATC 22 asserts that "the value matches the retrieval URI for an existing NetworkLink element (kml:NetworkLink/kml:Link/kml:href)". This is not quite right; more precisely, the kml:Update/kml:targetHref element refers to the original KML data to be updated. The NetworkLink element is just a mechanism for supplying the data to some earth browser implementation.

Hours Worked: 0.00
Entered By: Martell, Richard - 2014-10-23 11:54:13
Status: Fixed - Requires Review
Assigned To: Martell, Richard

Fixed in r8. verifyUpdateTarget now checks updates against the original data (see ETSAssert.assertValidUpdate).


For each targetId attribute appearing in the update, the expression //kml:*[@id = targetId] must evaluate to 'true' when evaluated against the referenced data (kml:targetHref).

Hours Worked: 0.00
Entered By: Martell, Richard - 2014-03-20 12:38:07
Status: Closed (Change Required)
Assigned To: Martell, Richard

Hours Worked: 0.00
Entered By: Bermudez, Luis - 2014-07-24 09:04:11